Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubernetes_state.statefulset.count metric #9813

Merged
merged 5 commits into from
Aug 19, 2021
Merged

Add kubernetes_state.statefulset.count metric #9813

merged 5 commits into from
Aug 19, 2021

Conversation

nammn
Copy link
Contributor

@nammn nammn commented Aug 2, 2021 •
edited
Loading

What does this PR do?

Adds kubernetes_state.statefulset.count based on generations, which is based on the same code and methods that deployment.count is using

Motivation

OOTB sts dashboard

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@nammn nammn changed the title [kubernetes_state] add sts count [kubernetes_state] [Added] KSM kubernetes_state.statefulset.count metric. Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021 •
edited
Loading

Codecov Report

Merging #9813 (2b9b016) into master (9f4d47e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Flag Coverage Δ
datadog_checks_base 89.59% <ø> (+0.38%) ⬆️
iis 93.01% <ø> (+0.59%) ⬆️
kubernetes_state 89.73% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nammn nammn marked this pull request as ready for review August 2, 2021 09:03
@nammn nammn requested review from a team as code owners August 2, 2021 09:03
@nammn nammn requested a review from a team August 2, 2021 09:03
FlorianVeaux
FlorianVeaux requested changes Aug 2, 2021
View reviewed changes
kubernetes_state/CHANGELOG.md Outdated Show resolved Hide resolved
@FlorianVeaux
Update kubernetes_state/CHANGELOG.md
2b9b016 
Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com>
@FlorianVeaux FlorianVeaux changed the title [kubernetes_state] [Added] KSM kubernetes_state.statefulset.count metric. Add kubernetes_state.statefulset.count metric Aug 2, 2021
cswatt
cswatt approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good docs-wise

@nammn nammn mentioned this pull request Aug 4, 2021
Merged
4 tasks
djmitche
djmitche approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from agent-core

@FlorianVeaux FlorianVeaux merged commit ce14eb9 into master Aug 19, 2021
@FlorianVeaux FlorianVeaux deleted the nnguyen/add-sts branch August 19, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@mfpierre mfpierre mfpierre approved these changes

@cswatt cswatt cswatt approved these changes

@djmitche djmitche djmitche approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nammn @djmitche @cswatt @mfpierre @ChristineTChen @FlorianVeaux