Use display_default
as a fallback for default
when validating config models
#9739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use
display_default
instead ofdefault
when validating models.Example
In kafka_consumer check, default for the optional
kafka_client_api_version
isNone
but an example value is shown as2.3.0
. However, the generateddefaults.py
currently takes the value fromdefault
> thenexample
> then falls back to NO_DEFAULT aka<KAFKA_CLIENT_API_VERSION>
spec.yaml
- https://github.com/DataDog/integrations-core/blob/7.30.x/kafka_consumer/assets/configuration/spec.yamlconf.yaml.example
- https://github.com/DataDog/integrations-core/blob/7.30.x/kafka_consumer/datadog_checks/kafka_consumer/data/conf.yaml.example#L56-L65defaults.py
Example 2: https://github.com/DataDog/integrations-core/pull/9699/files#r672222987
Motivation
#8593
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached