Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SHUNNED_REPLICATION_LAG status for proxysql.backend.status service check #9738

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Support SHUNNED_REPLICATION_LAG status for proxysql.backend.status service check #9738

merged 3 commits into from
Jul 21, 2021

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Jul 20, 2021 •
edited
Loading

What does this PR do?

Add a new service check mapping for SHUNNED_REPLICATION_LAG to CRITICAL for proxysql.backend.status. Current behavior maps it to UNKNOWN

Motivation

Escalation/FR from a ticket

Additional Notes

Link to proxysql statuses:
https://github.com/sysown/proxysql/blob/bd3e96a015da802320beb2ba96b0270cf00cb28e/include/proxysql_structs.h#L18

Sample output from proxysql:

MySQL [(none)]> SELECT status FROM stats_mysql_connection_pool\G

status: SHUNNED_REPLICATION_LAG

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@steveny91 steveny91 requested a review from a team as a code owner July 20, 2021 23:49
@ghost ghost added the integration/proxysql label Jul 20, 2021
@codecov
Copy link

codecov bot commented Jul 20, 2021 •
edited
Loading

Codecov Report

Merging #9738 (873f2d0) into master (499dbff) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
proxysql 99.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ofek
ofek requested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's edit the comment above with that source code link

@ofek ofek changed the title add status mapping for shunned_replication_lag Support SHUNNED_REPLICATION_LAG status for proxysql.backend.status service check Jul 21, 2021
@steveny91 steveny91 requested a review from ofek July 21, 2021 16:07
ofek
ofek approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ofek ofek merged commit b73ac2d into master Jul 21, 2021
@ofek ofek deleted the steveny91/add_status_replag_shun branch July 21, 2021 19:06
github-actions bot pushed a commit that referenced this pull request Jul 21, 2021
@ofek
Support SHUNNED_REPLICATION_LAG status for `proxysql.backend.status…
7675991 
…` service check (#9738)

* add status mapping for shunned_replication_lag

* added some notes to comments about SHUNNED_REPLICATION_LAG

* style fix b73ac2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/proxysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveny91 @ofek