Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support username/password as alternative to user/pass #9340

Merged
merged 6 commits into from
Jun 30, 2021
Merged

Support username/password as alternative to user/pass #9340

merged 6 commits into from
Jun 30, 2021

Conversation

ian28223
Copy link
Contributor

What does this PR do?

  • Support password as alternative to pass - 2 integrations affected
  • Support username as alternative to user- 4 integrations affected

Motivation

AGENT-6199

Additional Notes

  • I decided not to include user as alternative to username
  • skipped Process check since user is more in line with process_owner than a username usually for logons.
  • skipped SNMP since code appears to look for user specifically

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ian28223 ian28223 requested a review from a team as a code owner May 12, 2021 05:43
@codecov
Copy link

codecov bot commented May 12, 2021 •
edited
Loading

Codecov Report

Merging #9340 (329568b) into master (3b4bb12) will increase coverage by 0.01%.
The diff coverage is 71.42%.

Flag Coverage Δ
active_directory 100.00% <ø> (ø)
activemq_xml 82.31% <ø> (ø)
aerospike 86.97% <ø> (+0.36%) ⬆️
airflow 89.94% <ø> (ø)
amazon_msk 87.31% <ø> (-0.51%) ⬇️
ambari 86.98% <ø> (ø)
apache 95.39% <ø> (ø)
aspdotnet 93.87% <ø> (ø)
azure_iot_edge 82.01% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 83.95% <ø> (ø)
cassandra_nodetool 94.19% <ø> (ø)
ceph 91.02% <ø> (ø)
cilium 85.84% <ø> (+1.88%) ⬆️
cisco_aci 95.88% <ø> (ø)
clickhouse 96.55% <66.66%> (-0.41%) ⬇️
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cockroachdb 97.18% <ø> (ø)
consul 93.04% <ø> (-0.38%) ⬇️
coredns 96.36% <ø> (ø)
couch 95.15% <ø> (+0.24%) ⬆️
couchbase 81.45% <ø> (ø)
crio 100.00% <ø> (ø)
datadog_checks_base 89.59% <ø> (+0.41%) ⬆️
datadog_checks_dev 80.39% <ø> (ø)
datadog_checks_downloader 80.40% <ø> (ø)
directory 94.70% <ø> (ø)
disk 91.00% <ø> (-0.51%) ⬇️
dns_check 94.00% <ø> (-0.45%) ⬇️
dotnetclr 100.00% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 77.65% <ø> (+0.25%) ⬆️
eks_fargate 94.05% <ø> (ø)
elastic 88.54% <ø> (ø)
envoy 93.77% <ø> (+0.25%) ⬆️
etcd 93.09% <ø> (ø)
exchange_server 100.00% <ø> (ø)
external_dns 100.00% <ø> (ø)
fluentd 94.77% <ø> (ø)
gearmand 77.27% <ø> (+1.29%) ⬆️
gitlab 89.94% <ø> (ø)
gitlab_runner 90.32% <ø> (ø)
glusterfs 80.09% <ø> (+0.92%) ⬆️
go_expvar 91.95% <ø> (ø)
gunicorn 93.53% <ø> (ø)
haproxy 95.22% <ø> (+0.17%) ⬆️
harbor 91.58% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 90.00% <ø> (ø)
hdfs_namenode 87.94% <ø> (ø)
http_check 89.96% <ø> (+1.82%) ⬆️
ibm_db2 93.87% <ø> (ø)
ibm_mq 90.19% <ø> (ø)
ibm_was 97.44% <ø> (ø)
iis 92.41% <ø> (ø)
istio 93.25% <ø> (+0.56%) ⬆️
kafka_consumer 81.15% <ø> (ø)
kong 92.21% <ø> (-1.12%) ⬇️
kube_apiserver_metrics 97.35% <ø> (ø)
kube_controller_manager 97.05% <ø> (ø)
kube_dns 98.85% <ø> (ø)
kube_metrics_server 100.00% <ø> (ø)
kube_proxy 100.00% <ø> (ø)
kube_scheduler 98.07% <ø> (ø)
kubelet 89.47% <ø> (ø)
kubernetes_state 89.69% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 86.12% <ø> (+0.24%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapr 84.18% <ø> (ø)
mapreduce 82.27% <ø> (ø)
marathon 83.12% <ø> (ø)
marklogic 95.32% <ø> (ø)
mcache 93.39% <ø> (ø)
mesos_master 89.68% <ø> (-0.94%) ⬇️
mesos_slave 93.63% <ø> (ø)
mongo 94.74% <ø> (+0.28%) ⬆️
mysql 85.48% <66.66%> (+0.09%) ⬆️
nagios 89.53% <ø> (ø)
network 77.76% <ø> (+1.00%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx 95.11% <ø> (+0.93%) ⬆️
nginx_ingress_controller 98.30% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 97.14% <ø> (ø)
openstack 51.30% <ø> (ø)
openstack_controller 90.59% <ø> (ø)
oracle 92.99% <33.33%> (+0.04%) ⬆️
pdh_check 97.77% <ø> (ø)
pgbouncer 91.50% <ø> (ø)
php_fpm 89.95% <ø> (+0.43%) ⬆️
postfix 88.04% <ø> (ø)
postgres 92.02% <ø> (+0.25%) ⬆️
powerdns_recursor 95.93% <ø> (ø)
process 85.12% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 99.62% <ø> (ø)
rabbitmq 93.73% <ø> (ø)
redisdb 87.26% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riak 99.22% <ø> (ø)
riakcs 93.61% <ø> (ø)
sap_hana 93.04% <ø> (ø)
scylla 100.00% <ø> (ø)
snmp 91.57% <ø> (+0.04%) ⬆️
snowflake 94.18% <66.66%> (+0.32%) ⬆️
sonarqube 95.69% <ø> (ø)
spark 93.64% <ø> (+0.17%) ⬆️
sqlserver 81.74% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 91.08% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
supervisord 92.30% <100.00%> (+0.12%) ⬆️
system_core 91.04% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 86.53% <ø> (ø)
teamcity 80.00% <ø> (ø)
tls 97.04% <ø> (+0.87%) ⬆️
tokumx 58.40% <ø> (?)
twemproxy 78.33% <ø> (ø)
twistlock 80.74% <ø> (ø)
varnish 84.57% <ø> (+0.24%) ⬆️
vault 94.80% <ø> (+0.54%) ⬆️
vertica 92.30% <ø> (ø)
voltdb 96.81% <ø> (ø)
vsphere 89.77% <ø> (+0.08%) ⬆️
win32_event_log 86.03% <ø> (+0.28%) ⬆️
windows_service 95.83% <ø> (ø)
wmi_check 92.91% <ø> (ø)
yarn 90.30% <ø> (ø)
zk 85.17% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

hithwen
hithwen previously approved these changes May 17, 2021
View reviewed changes
ofek
ofek requested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should document these and support the old key as a deprecated fallback. WDYT @hithwen?

@hithwen
Copy link
Contributor

hithwen commented Jun 14, 2021 •
edited
Loading

IMO we should document these and support the old key as a deprecated fallback. WDYT @hithwen?

I agree, its more consistent with the rest of integrations

@ian28223 ian28223 force-pushed the ian.bucad/alt_user_pass branch from 37caab5 to a4fda47 Compare June 23, 2021 07:55
@ian28223 ian28223 requested review from a team as code owners June 23, 2021 07:55
ruthnaebeck
ruthnaebeck previously approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@ofek
Copy link
Contributor

ofek commented Jun 29, 2021

oracle is failing

@ofek ofek changed the title support username/password as alternative to user/pass Support username/password as alternative to user/pass Jun 30, 2021
@ofek ofek merged commit 6728e2a into master Jun 30, 2021
@ofek ofek deleted the ian.bucad/alt_user_pass branch June 30, 2021 12:46
github-actions bot pushed a commit that referenced this pull request Jun 30, 2021
@ofek
Support username/password as alternative to user/pass (#9340)
34462b8 
* Support pass or password

* support username as alternative to user

* Log deprecation

* Update config files

* model validate

* oracle test 6728e2a
@coignetp coignetp mentioned this pull request Jul 9, 2021
Merged
4 tasks
@FlorianVeaux FlorianVeaux mentioned this pull request Jul 21, 2021
Closed
@ofek ofek mentioned this pull request Jul 21, 2021
Merged
@frivoire
Copy link
Contributor

I've recently seen the deprecation warning in logs:

2022-11-09 17:52:22 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:125 in LogMessage) | mysql:723bfeaaebaaf50b | (base.py:868) | DEPRECATION NOTICE: The user config option has been renamed to username and will be removed in a future release.

And I found this PR that did the change
But the documentation is still giving the old user parameter, cf: https://docs.datadoghq.com/integrations/mysql/?tab=kubernetes#configuration

doc

Can someone fix this ?

@ian28223
Copy link
Contributor Author

ian28223 commented Nov 16, 2022 via email

@frivoire
Copy link
Contributor

@ian28223: I'm not sure you meant that it's done, but from my point of view, it doesn't seem so (same state than on my screenshot above)

@frivoire
Copy link
Contributor

The documentation is still not updated and contains the pre-2021 syntax 😢
Can someone update it please 🙏

ian28223 added a commit that referenced this pull request Jul 26, 2023
@ian28223
Doc update based on #9340
03fe460
@ian28223 ian28223 mentioned this pull request Jul 26, 2023
Merged
5 tasks
ian28223 added a commit that referenced this pull request Jul 26, 2023
@ian28223
Doc update based on #9340
6934222
FlorentClarret pushed a commit that referenced this pull request Jul 27, 2023
@ian28223
Doc update based on #9340 (#15380)
6adebe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@ruthnaebeck ruthnaebeck ruthnaebeck left review comments

@hithwen hithwen hithwen left review comments

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/clickhouse integration/datadog_checks_base integration/mysql integration/oracle integration/snowflake integration/supervisord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ian28223 @hithwen @ofek @frivoire @ruthnaebeck