Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime configuration validation #9004

Merged
merged 1 commit into from
May 19, 2021
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 22, 2021

What does this PR do?

Adds config models from #8675

@ofek ofek requested a review from a team as a code owner March 22, 2021 17:48
@ofek ofek force-pushed the ofek/sync_config_models_voltdb branch from b89678b to e378eab Compare March 23, 2021 14:39
@ofek ofek changed the title Sync config models Add runtime configuration validation Mar 23, 2021
@hithwen
Copy link
Contributor

hithwen commented May 17, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hithwen
Copy link
Contributor

hithwen commented May 17, 2021

voltdb:
    File `defaults.py` is not in sync, run "ddev validate models -s"
    File `instance.py` is not in sync, run "ddev validate models -s"

@ofek ofek force-pushed the ofek/sync_config_models_voltdb branch 2 times, most recently from bdce9f0 to 39a7384 Compare May 19, 2021 19:28
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #9004 (b029237) into master (944fed0) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
voltdb 96.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

luisgonzalex
luisgonzalex previously approved these changes May 19, 2021
@ofek ofek force-pushed the ofek/sync_config_models_voltdb branch from 39a7384 to b029237 Compare May 19, 2021 20:01
@ofek ofek merged commit 2fc7c56 into master May 19, 2021
@ofek ofek deleted the ofek/sync_config_models_voltdb branch May 19, 2021 20:11
github-actions bot pushed a commit that referenced this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants