Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize time precision function from datadog_checks_base #8841

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Utilize time precision function from datadog_checks_base #8841

merged 2 commits into from
Mar 17, 2021

Conversation

mgarabed
Copy link
Member

What does this PR do?

Building on top of #8838 this PR migrates the related time code to utilize the new base check functionality.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@mgarabed mgarabed requested a review from a team as a code owner March 16, 2021 21:50
@mgarabed mgarabed merged commit 5798711 into master Mar 17, 2021
@mgarabed mgarabed deleted the mg/time-factor-checks branch March 17, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/dns_check integration/sqlserver integration/tcp_check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgarabed @ofek