Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include validate_cert in backwards compatibility remapper #8543

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Include validate_cert in backwards compatibility remapper #8543

merged 1 commit into from
Feb 5, 2021

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Feb 4, 2021 •
edited
Loading

What does this PR do?

The validate_cert option is not backwards compatible with the tls context remapper.

https://github.com/DataDog/integrations-core/blob/7.23.x/tls/datadog_checks/tls/data/conf.yaml.example#L62-L71

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested a review from a team as a code owner February 4, 2021 23:34
@ghost ghost added the integration/tls label Feb 4, 2021
florimondmanca
florimondmanca approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@florimondmanca florimondmanca merged commit bd555f3 into master Feb 5, 2021
@florimondmanca florimondmanca deleted the cc/fix-tls-missing branch February 5, 2021 09:34
florimondmanca pushed a commit that referenced this pull request Feb 5, 2021
@ChristineTChen
Include validate_cert in backwards compatibility remapper (#8543)
5170835
florimondmanca pushed a commit that referenced this pull request Feb 5, 2021
@ChristineTChen
Include validate_cert in backwards compatibility remapper (#8543)
cdcfba7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @ofek @florimondmanca