Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ActiveMQ Artemis #8527

Merged
merged 14 commits into from
Feb 24, 2021
Merged

Add support for ActiveMQ Artemis #8527

merged 14 commits into from
Feb 24, 2021

Conversation

mgarabed
Copy link
Member

@mgarabed mgarabed commented Feb 3, 2021

What does this PR do?

Extends the ActiveMQ integration to support ActiveMQ Artemis.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the integration/activemq label Feb 3, 2021
@mgarabed mgarabed marked this pull request as ready for review February 8, 2021 15:52
@mgarabed mgarabed requested a review from a team as a code owner February 8, 2021 15:52
@florimondmanca
Copy link
Contributor

@mgarabed Do we need to make any updates to README or other metadata (?) files?

ChristineTChen
ChristineTChen previously approved these changes Feb 8, 2021
View reviewed changes
@mgarabed mgarabed requested a review from a team as a code owner February 8, 2021 21:30
@ghost ghost added the documentation label Feb 8, 2021
apigirl
apigirl previously approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

florimondmanca
florimondmanca reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Planning to play with this locally today, but the code looks good.

ChristineTChen
ChristineTChen reviewed Feb 23, 2021
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions on metric types

@mgarabed @ChristineTChen
Update activemq/README.md
144ee6c 
Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com>
ofek
ofek previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgarabed mgarabed merged commit 3ae6bd7 into master Feb 24, 2021
@mgarabed mgarabed deleted the mg/artemis-jmx branch February 24, 2021 18:36
github-actions bot pushed a commit that referenced this pull request Feb 24, 2021
@mgarabed
Add support for ActiveMQ Artemis (#8527)
ac6ff53 
* Initial Artemis JMX integration

* Add artemis metrics and e2e env

* Add test queues for artemis env

* Remove new integration files

* Update metadata

* Update e2e tests

* Fix style

* Update README

* Add address metrics

* Update tests

* Update activemq/README.md

Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com>

* Update metric types

* Fix metadata

* Update metric types and add rate test

Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com> 3ae6bd7
@florimondmanca florimondmanca mentioned this pull request Mar 11, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca left review comments

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@ofek ofek ofek left review comments

@apigirl apigirl apigirl left review comments

Assignees
No one assigned
Labels
documentation integration/activemq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mgarabed @florimondmanca @ofek @ChristineTChen @apigirl