Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'Context limit reached' message a warning #8254

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Make 'Context limit reached' message a warning #8254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka_consumer/datadog_checks/kafka_consumer/kafka_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def check(self, instance):
if len(self._consumer_offsets) < self._context_limit:
self._get_highwater_offsets()
else:
self.log.debug("Context limit reached. Skipping highwater offset collection.")
self.warning("Context limit reached. Skipping highwater offset collection.")
except Exception:
self.log.exception("There was a problem collecting the highwater mark offsets.")
# Unlike consumer offsets, fail immediately because we can't calculate consumer lag w/o highwater_offsets
Expand Down
8 changes: 4 additions & 4 deletions kafka_consumer/datadog_checks/kafka_consumer/legacy_0_10_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def _get_highwater_offsets(self, contexts_limit):

for broker in self._kafka_client.cluster.brokers():
if len(self._highwater_offsets) >= contexts_limit:
self.log.debug("Context limit reached. Skipping highwater offsets collection.")
self.warning("Context limit reached. Skipping highwater offsets collection.")
return
broker_led_partitions = self._kafka_client.cluster.partitions_for_broker(broker.nodeId)
if broker_led_partitions is None:
Expand Down Expand Up @@ -237,7 +237,7 @@ def _process_highwater_offsets(self, response, contexts_limit):
if error_type is kafka_errors.NoError:
self._highwater_offsets[(topic, partition)] = offsets[0]
if len(self._highwater_offsets) >= contexts_limit:
self.log.debug("Context limit reached. Skipping highwater offsets processing.")
self.warning("Context limit reached. Skipping highwater offsets processing.")
return
elif error_type is kafka_errors.NotLeaderForPartitionError:
self.log.warning(
Expand Down Expand Up @@ -374,7 +374,7 @@ def _get_zk_consumer_offsets(self, contexts_limit):
self._zk_consumer_offsets[key] = consumer_offset

if len(self._zk_consumer_offsets) >= contexts_limit:
self.log.debug("Context limit reached. Skipping zk consumer offsets collection.")
self.warning("Context limit reached. Skipping zk consumer offsets collection.")
return
except NoNodeError:
self.log.info('No zookeeper node at %s', zk_path)
Expand Down Expand Up @@ -424,7 +424,7 @@ def _get_kafka_consumer_offsets(self, contexts_limit):
self._kafka_consumer_offsets[key] = offset

if len(self._kafka_consumer_offsets) >= contexts_limit:
self.log.debug("Context limit reached. Skipping kafka consumer offsets collection.")
self.warning("Context limit reached. Skipping kafka consumer offsets collection.")
return
else:
self.log.info("unable to find group coordinator for %s", consumer_group)
Expand Down