Fix deployment count metric #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cd90a2 to
83544ff
Compare
Codecov Report
|
xlucas
reviewed
Dec 23, 2020
| @@ -869,7 +867,7 @@ def kube_limitrange(self, metric, scraper_config): | |||
| else: | |||
| self.log.error("Metric type %s unsupported for metric %s", metric.type, metric.name) | |||
|
|
|||
| def count_objects_by_tags(self, metric, scraper_config): | |||
| def count_values_by_tags(self, metric, scraper_config): | |||
| """ Count objects by allowed tags and submit counts as gauges. """ | |||
There was a problem hiding this comment.
Nit: could rephrase the comment to mention the difference between count_objects and count_values
There was a problem hiding this comment.
renamed to sum_values_by_tags to be clearer
a2cb1fb to
0cd89f6
Compare
xlucas
approved these changes
Dec 23, 2020
ChristineTChen
pushed a commit
that referenced
this pull request
Dec 23, 2020
* Split count_objects_by_tags from count_values_by_tags * Assert on count values * Update docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Count the number of objects instead of summing up values for certain count metrics.
Otherwise the deployment count metric would sum up the number of deployment generations
Motivation
Fix deployment count metric
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached