Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kafka Consumer spec #8108

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Add Kafka Consumer spec #8108

merged 4 commits into from
Dec 9, 2020

Conversation

gsalami00
Copy link
Contributor

What does this PR do?

Adds spec.yaml for the configuration.

Motivation

https://datadoghq.dev/integrations-core/meta/status/#config-specs

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@gsalami00 gsalami00 requested review from a team as code owners November 30, 2020 22:21
@ghost ghost added the documentation label Nov 30, 2020
ChristineTChen
ChristineTChen requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also bump the version here to 11.0.0
https://github.com/DataDog/integrations-core/blob/master/kafka_consumer/setup.py#L31

kafka_consumer/assets/configuration/spec.yaml Show resolved Hide resolved
kafka_consumer/datadog_checks/kafka_consumer/data/conf.yaml.example Outdated Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 30, 2020 •
edited
Loading

Codecov Report

Merging #8108 (ffe7c09) into master (b86866b) will decrease coverage by 6.89%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_base/datadog_checks/base/log.py
go_expvar/tests/test_integration.py
datadog_checks_dev/tests/tooling/test_release.py
...tadog_checks_dev/datadog_checks/dev/tooling/git.py
hivemq/tests/conftest.py
process/datadog_checks/process/process.py
...base/datadog_checks/base/utils/metadata/version.py
fluentd/tests/mock/fluentd_version.py
ibm_mq/datadog_checks/ibm_mq/stats/queue_stats.py
openstack/datadog_checks/openstack/__about__.py
... and 878 more

apigirl
apigirl reviewed Dec 1, 2020
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small comment about discussing planned future changes

kafka_consumer/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
@gsalami00 gsalami00 requested a review from apigirl December 1, 2020 15:16
ChristineTChen
ChristineTChen requested changes Dec 1, 2020
View reviewed changes
kafka_consumer/assets/configuration/spec.yaml Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kafka_consumer/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
@ChristineTChen
Copy link
Contributor

LGTM! Waiting on approval from @apigirl

apigirl
apigirl approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I missed your ping on this last week, thanks for being patient

@coignetp coignetp mentioned this pull request Dec 9, 2020
Merged
4 tasks
@ChristineTChen ChristineTChen merged commit e986b41 into master Dec 9, 2020
@ChristineTChen ChristineTChen deleted the gsalami/kafka_consumer_spec_yaml branch December 9, 2020 15:51
github-actions bot pushed a commit that referenced this pull request Dec 9, 2020
@ChristineTChen
Add Kafka Consumer spec (#8108)
1dcabf7 
* Add Kafka Consumer spec

* Update spec.yaml

* Update Kafka Consumer spec

* Update Kafka spec e986b41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen requested changes

@apigirl apigirl apigirl approved these changes

Assignees
No one assigned
Labels
documentation integration/kafka_consumer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsalami00 @ChristineTChen @apigirl