Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config specs #8096

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Add config specs #8096

merged 3 commits into from
Dec 1, 2020

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few grammar and style edits.

openldap/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
openldap/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
openldap/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
openldap/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
openldap/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
openldap/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
Comment on lines 58 to 66
## * `name` - string - required: A name to identify your query. It's used to tag the metrics for this query.
## * `search_base` - string - required: The search base for the query.
## * `search_filter` - string - required: The search filter for your query.
## * `search_scope` - string - optional - default: subtree : One of `base`, `level`, `subtree`.
## * `attributes` - list of strings - optional: List of attributes to query.
## * `username` - string - optional: The user you want to bind to perform the query.
## Don't specify the option if you want to use the same user as
## for the monitor backend. Set to empty string `""` for an anonymous bind.
## * `password` - string - optional: The password associated with `username`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments as above

coignetp and others added 2 commits November 27, 2020 09:23
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@coignetp coignetp merged commit d01ce7a into master Dec 1, 2020
@coignetp coignetp deleted the paul/openldap-spec branch December 1, 2020 11:19
github-actions bot pushed a commit that referenced this pull request Dec 1, 2020
* Add config specs

* Apply suggestions from code review

Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>

* Sync configuration

Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> d01ce7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants