-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config specs #8096
Merged
Merged
Add config specs #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayayarai
requested changes
Nov 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few grammar and style edits.
Comment on lines
58
to
66
## * `name` - string - required: A name to identify your query. It's used to tag the metrics for this query. | ||
## * `search_base` - string - required: The search base for the query. | ||
## * `search_filter` - string - required: The search filter for your query. | ||
## * `search_scope` - string - optional - default: subtree : One of `base`, `level`, `subtree`. | ||
## * `attributes` - list of strings - optional: List of attributes to query. | ||
## * `username` - string - optional: The user you want to bind to perform the query. | ||
## Don't specify the option if you want to use the same user as | ||
## for the monitor backend. Set to empty string `""` for an anonymous bind. | ||
## * `password` - string - optional: The password associated with `username`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comments as above
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
ChristineTChen
approved these changes
Nov 30, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Dec 1, 2020
* Add config specs * Apply suggestions from code review Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> * Sync configuration Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> d01ce7a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached