Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sap hana config spec #7715

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Add sap hana config spec #7715

merged 4 commits into from
Oct 23, 2020

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Oct 5, 2020

What does this PR do?

Add config spec for sap_hana

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested review from a team as code owners October 5, 2020 13:04
coignetp
coignetp commented Oct 5, 2020
View reviewed changes
sap_hana/datadog_checks/sap_hana/data/conf.yaml.example
instances:

## @param server - string - required
## The hostname used to connect to the system.
#
- server: <SERVER>

## @param port - integer - required - default: 39015
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default port is 30015 (see

integrations-core/sap_hana/datadog_checks/sap_hana/sap_hana.py

Line 33 in ff62dcf

self._port = self.instance.get('port', 30015)
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofek Seems both port are valid, 39015 being "HXE2" and 30015 for "HXE1".
Any idea which one we should default to?

@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #7715 into master will increase coverage by 1.96%.
The diff coverage is n/a.

Impacted Files Coverage Δ
kube_dns/datadog_checks/kube_dns/__init__.py
...xternal_dns/datadog_checks/external_dns/metrics.py
linux_proc_extras/tests/common.py
disk/tests/common.py
cacti/tests/conftest.py
linux_proc_extras/tests/test_integration.py
mapr/datadog_checks/mapr/__about__.py
cilium/tests/common.py
confluent_platform/tests/metrics.py
cisco_aci/datadog_checks/cisco_aci/fabric.py
... and 324 more

@coignetp coignetp changed the title Add config spec Add sap hana config spec Oct 5, 2020
@coignetp coignetp marked this pull request as draft October 5, 2020 14:49
@coignetp coignetp marked this pull request as ready for review October 6, 2020 14:58
yzhan289
yzhan289 previously approved these changes Oct 9, 2020
View reviewed changes
kayayarai
kayayarai previously requested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple documentation suggestions

sap_hana/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
sap_hana/datadog_checks/sap_hana/data/conf.yaml.example Show resolved Hide resolved
@florimondmanca florimondmanca dismissed stale reviews from kayayarai and ChristineTChen October 23, 2020 10:24

Addressed

@coignetp coignetp merged commit 10cfc97 into master Oct 23, 2020
@coignetp coignetp deleted the paul/sap-spec branch October 23, 2020 12:11
github-actions bot pushed a commit that referenced this pull request Oct 23, 2020
@coignetp
Add sap hana config spec (#7715)
db6a340 
* Add config spec

* Use db template

* Remove useless attribute

* Add timeout unit 10cfc97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux left review comments

@ofek ofek ofek left review comments

@florimondmanca florimondmanca florimondmanca approved these changes

@yzhan289 yzhan289 yzhan289 left review comments

@ChristineTChen ChristineTChen ChristineTChen left review comments

@kayayarai kayayarai kayayarai left review comments

Assignees
No one assigned
Labels
documentation integration/sap_hana
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@coignetp @ofek @kayayarai @ChristineTChen @florimondmanca @FlorianVeaux @yzhan289