add labels from self.SAMPLE_LABELS to container status metrics
#7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
|
Hi @jfmyers9, thanks for the contribution the changes look good. It would be great if you could add a unit test. |
Users rely on label_join to associate labels from the `kube_pod_labels` with other `kube_pod_*` metrics. We were previously dropping these labels for these two metrics. This ensures that labels associated with pods end up on the `kubernetes_state.container.status_report.*` metrics. This is similar to how `SAMPLE_LABELS` are processes for other resources in the check.
eadfcec to
a76f1a3
Compare
|
@ahmed-mez Added the metric to the existing |
ahmed-mez
approved these changes
Oct 6, 2020
|
Any update on this pull request? Our team is looking to utilize labels to improve monitoring of |
FlorianVeaux
approved these changes
Oct 12, 2020
|
thanks @jfmyers9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change respects the pod_labels from label_joins when emitting the container status metrics.
This is similar to how
SAMPLE_LABELSare processes for other resources in the check.Motivation
Users rely on label_join to associate labels from the
kube_pod_labelswith otherkube_pod_*metrics. For example, we rely on various labels to help us route alerts to the correct team for metrics within monitors.Additional Notes
Nope.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached