Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent formatting for boolean values #7405

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 20, 2020

What does this PR do?

  • Have a consistent format on rendered default values.

Motivation

  • If setting default: true on the configuration specification of a check, it will be rendered as default: True, instead of default: true, which is what happens when setting example: true.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@hithwen hithwen merged commit b6511a8 into master Aug 20, 2020
@hithwen hithwen deleted the mx-psi/repr-config-validator branch August 20, 2020 13:00
@ofek ofek changed the title [datadog_checks_dev] Use consistent formatting for boolean values Use consistent formatting for boolean values Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment