Add domain to metrics.yaml #7164

hithwen · 2020-07-21T10:53:38Z

Background information: #7054
TL;DR: This prevents jmx fetch from scanning unrelated beans

hithwen · 2020-07-21T11:18:06Z

I had to remove the domain in a few metrics b4fc35f even though they come with the jmx_domain:solr tag

codecov · 2020-07-21T11:21:55Z

Codecov Report

Merging #7164 into master will decrease coverage by 26.82%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
...oller/datadog_checks/openstack_controller/retry.py
envoy/tests/conftest.py
mesos_slave/tests/test_integration.py
vertica/tests/conftest.py
...tadog_checks/nginx_ingress_controller/__about__.py
amazon_msk/tests/test_unit.py
...tadog_checks/rethinkdb/document_db/transformers.py
...datanode/datadog_checks/hdfs_datanode/__about__.py
envoy/tests/test_metrics.py
envoy/datadog_checks/envoy/envoy.py
... and 1022 more

Add domain to metrics.yaml

8e60730

hithwen requested a review from a team as a code owner July 21, 2020 10:53

hithwen added the changelog/Fixed label Jul 21, 2020

github-actions bot added the integration/solr label Jul 21, 2020

Remove some domains

b4fc35f

Correct domain name

2cf8b66

AlexandreYang approved these changes Jul 21, 2020

View reviewed changes

hithwen merged commit 7537fc9 into master Jul 21, 2020

hithwen deleted the julia/AI-975-add-domain-specifier-to-solr branch July 21, 2020 13:34