Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of reported contexts #7084

Merged
merged 6 commits into from
Jul 15, 2020

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jul 8, 2020

The Kafka consumer checks counts the total number of submitted context and displays a warning when the check submits too many metrics.
But the check still collects all metrics, this is a regression introduced here: c4a29b1

On the legacy implementation the limit is applied at collection time. However, as the new implementation uses futures to perform the collection this strategy can only be partially applied and so the limit is applied on submission time.

@hithwen hithwen requested a review from a team as a code owner July 8, 2020 12:54
@hithwen hithwen force-pushed the julia/AI-875-fix-max-partition-contexts branch from d55105f to 283b30d Compare July 8, 2020 12:56
@hithwen hithwen force-pushed the julia/AI-875-fix-max-partition-contexts branch 2 times, most recently from 4329653 to ae4fff1 Compare July 8, 2020 13:11
@hithwen hithwen force-pushed the julia/AI-875-fix-max-partition-contexts branch from ae4fff1 to 35a4e21 Compare July 9, 2020 10:42
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few comments to make the new log messages consistent.

Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com>
@hithwen hithwen requested a review from ChristineTChen July 10, 2020 08:37
@hithwen hithwen force-pushed the julia/AI-875-fix-max-partition-contexts branch from b79a356 to a3bb5fa Compare July 10, 2020 10:59
@hithwen hithwen force-pushed the julia/AI-875-fix-max-partition-contexts branch from a3bb5fa to e1e18f5 Compare July 10, 2020 11:01
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@hithwen hithwen merged commit 503a3c4 into master Jul 15, 2020
@hithwen hithwen deleted the julia/AI-875-fix-max-partition-contexts branch July 15, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants