Maxime/cassandra nodetool fix #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
suggested changes
Aug 24, 2017
cassandra_nodetool/check.py
Outdated
| @@ -20,13 +20,20 @@ | |||
| 'MB': 1e6, | |||
| 'GB': 1e9, | |||
| 'TB': 1e12, | |||
|
|
|||
| # stating cassandra 3.11+ | |||
There was a problem hiding this comment.
s/stating/starting
even better, only available in cassandra 3.11 or later
cassandra_nodetool/conf.yaml.example
Outdated
| @@ -5,19 +5,19 @@ init_config: | |||
|
|
|||
| instances: | |||
|
|
|||
| # the list of keyspaces to monitor | |||
| # the list of keyspaces to monitor, an empty list will result in not metrics being sent | |||
4bbe713 to
514cdef
Compare
gml3ff
pushed a commit
that referenced
this pull request
May 14, 2020
Allow configuration of logs agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix integration to be compatible with the latest version of cassandra (3.11+).
Add more log to warn user about the default configuration producing no metrics.
Update the defautl configuration to produce a valid yaml if lines are commented out.