Add dependencies to setup.py #7030

mgarabed · 2020-06-30T20:37:02Z

Adds install_requires to setup.py

Installed the package locally, but didn't get the associated dependencies along with it.

trishankatdatadog

LGTM! Why did we not need this before?

codecov · 2020-06-30T20:50:20Z

Codecov Report

Merging #7030 into master will decrease coverage by 8.96%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
datadog_checks_base/tests/test_utils.py
..._fargate/datadog_checks/eks_fargate/eks_fargate.py
kong/tests/test_integration_e2e.py
active_directory/tests/test_active_directory.py
kafka/tests/conftest.py
datadog_checks_dev/datadog_checks/dev/__init__.py
openmetrics/tests/common.py
pgbouncer/tests/common.py
datadog_checks_dev/datadog_checks/dev/utils.py
istio/tests/test_istio_1_5.py
... and 881 more

ofek

We should do this instead: #6589

Add dependencies to setup.py

faf3799

mgarabed requested a review from trishankatdatadog as a code owner June 30, 2020 20:37

github-actions bot added the integration/datadog_checks_downloader label Jun 30, 2020

trishankatdatadog previously approved these changes Jun 30, 2020

View reviewed changes

ofek requested changes Jun 30, 2020

View reviewed changes

Update to optional deps

886ece0

mgarabed dismissed trishankatdatadog’s stale review via 886ece0 July 1, 2020 12:31

ofek added the changelog/Added label Jul 1, 2020

ofek approved these changes Jul 1, 2020

View reviewed changes

mgarabed added do-not-merge/HOLD and removed do-not-merge/HOLD labels Jul 1, 2020

mgarabed merged commit 39a6914 into master Jul 8, 2020

mgarabed deleted the mgarabed/update-downloader branch July 8, 2020 14:01