Add missing tags to profiles tables #6765
Conversation
Some tables were missing tags, this won't work when tables have multiple rows.
| name: hrSWRunTable | ||
| OID: 1.3.6.1.2.1.25.4.2 | ||
| symbols: | ||
| - name: hrSWRunStatus |
There was a problem hiding this comment.
Why is hrSWRunStatus removed?
There was a problem hiding this comment.
I'm not sure it makes sense to have both as a tag on the previous table and as a metric directly.
There was a problem hiding this comment.
I originally had it as a metric only, but then added it also as a tag since it was in hrSWRunPerfTable and seemed like the most fitting tag there. Would it make sense to keep it as a metric and tag with a different metric here?
There was a problem hiding this comment.
Possibly! We need to see which entry in that table would make sense for tagging as well then.
There was a problem hiding this comment.
We could tag with hrSWRunName
Codecov Report
|
Co-authored-by: Sarah Witt <witt.s@husky.neu.edu>
Some tables were missing tags, this won't work when tables have multiple
rows.