Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing metrics for static pods #6736

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

A regression was introduced in agent 6.15, preventing metric retrieval for static PODs with K8S < 1.15

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@vboulineau vboulineau requested a review from a team May 26, 2020 12:42
@vboulineau vboulineau requested a review from a team as a code owner May 26, 2020 12:42
@vboulineau vboulineau force-pushed the vboulineau/static_pod branch from bf18084 to ff4c94b Compare May 26, 2020 12:45
@vboulineau vboulineau force-pushed the vboulineau/static_pod branch from ff4c94b to 705cd7d Compare May 27, 2020 15:16
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6808e92). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
kubelet/datadog_checks/kubelet/prometheus.py 83.60% <100.00%> (ø)
kubelet/tests/test_kubelet.py 97.44% <100.00%> (ø)
kubelet/datadog_checks/kubelet/summary.py 77.77% <0.00%> (ø)
kubelet/datadog_checks/kubelet/kubelet.py 83.50% <0.00%> (ø)
kubelet/datadog_checks/kubelet/common.py 89.07% <0.00%> (ø)
kubelet/tests/test_prometheus.py 100.00% <0.00%> (ø)
kubelet/datadog_checks/kubelet/__init__.py 100.00% <0.00%> (ø)
kubelet/datadog_checks/kubelet/cadvisor.py 77.27% <0.00%> (ø)
... and 3 more

@vboulineau vboulineau merged commit cbeba01 into master Jun 18, 2020
@vboulineau vboulineau deleted the vboulineau/static_pod branch June 18, 2020 15:33
@AlexandreYang AlexandreYang changed the title kubelet: fix missing metrics for static pods Fix missing metrics for static pods Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants