Add string cache and web cache metrics #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
| name: Cache | ||
| attribute: | ||
| hitCount: | ||
| alias: tomcat.web.cache.hit_count |
There was a problem hiding this comment.
Suggested change
| alias: tomcat.web.cache.hit_count | |
| alias: tomcat.web_cache.hit_count |
To be consistant with the string cache maybe?
There was a problem hiding this comment.
I think . is more suitable for this case since it's hierarchal. tomcat > web > cache.
In contrast StringCache is one specific class.
Co-Authored-By: Florian Veaux <florian.veaux@datadoghq.com>
Co-Authored-By: Florian Veaux <florian.veaux@datadoghq.com>
AlexandreYang
commented
Apr 20, 2020
| @@ -7,13 +7,6 @@ | |||
|
|
|||
| HERE = get_here() | |||
|
|
|||
| """ | |||
| Metrics that are not produced by our e2e tests: | |||
There was a problem hiding this comment.
This comment has been replace by the new comment in metrics.yaml
eaf471e to
45d9e78
Compare
FlorianVeaux
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add string cache and web cache metrics.
StringCachemetrics might be useful to investigate performance cases like this one:Motivation
type: Cacheremoved, it does not exist.Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached