[kafka_consumer] discovery of groups, topics and partitions #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The consumer_groups, topics, and partitions arguments are each now optional. Any omitted values will be fetched from Zookeeper. If a value is omitted, the parent value must still be it's expected type (typically a dict). Modern Kafka consumers store their offset in Kafka rather than Zookeeper, but this PR does not add support for this. It's tricky because this check is much simpler if it assumes a single place can be queried for all consumer offsets, but currently there's no easy way to do that. Once KIP-88 is implemented, it will be much easier to add this functionality, although it would only work for Kafka brokers >= 0.10.2.0. In the meantime, you can instrument your individual kafka consumers to submit their offsets to Datadog.
gmmeyer
approved these changes
Jul 25, 2017
truthbk
added a commit
that referenced
this pull request
Jul 25, 2017
gml3ff
pushed a commit
that referenced
this pull request
May 14, 2020
* [repository] Fix gpg import for recent gpg versions The command we use to check the fingerprint of a gpg key doesn't work with gpg >= 2.1.16. Since version 2.2 is bundled with SLES 15, it is necessary to also use the new way of getting a gpg key's fingerprint. * Lint repository.rb * Put whole command on one line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-merging #612 to preserve history, apologies for the squash.