Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style checks failure #6134

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

florimondmanca
Copy link
Contributor

What does this PR do?

Fixes an issue with import styles that made style checks fail.

Motivation

Made CI in #6107 fail, see job logs: https://dev.azure.com/datadoghq/integrations-core/_build/results?buildId=11268&view=logs&jobId=a99fe294-74e6-5626-8ad8-bf38f5618435&j=a99fe294-74e6-5626-8ad8-bf38f5618435&t=e13d20aa-3dd4-5442-c1fb-77fea3251b6f

style run-test: commands[2] | isort --check-only --diff --recursive .
ERROR: /home/vsts/work/1/s/gunicorn/datadog_checks/gunicorn/gunicorn.py Imports are incorrectly sorted.
--- /home/vsts/work/1/s/gunicorn/datadog_checks/gunicorn/gunicorn.py:before	2020-03-24 14:58:30.631090
+++ /home/vsts/work/1/s/gunicorn/datadog_checks/gunicorn/gunicorn.py:after	2020-03-24 15:05:05.691401
@@ -15,7 +15,6 @@
 import psutil
 
 from datadog_checks.base import AgentCheck
-
 # project
 from datadog_checks.base.utils.subprocess_output import get_subprocess_output
 
ERROR: InvocationError for command /home/vsts/work/1/s/gunicorn/.tox/style/bin/isort --check-only --diff --recursive . (exited with code 1)

Additional Notes

Cleanup for #6088

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@florimondmanca florimondmanca merged commit 2e0e1d3 into master Mar 24, 2020
@florimondmanca florimondmanca deleted the florimondmanca/fix-gunicorn-import-styles branch March 24, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants