Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline exception handling #6003

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Streamline exception handling #6003

merged 2 commits into from
Mar 10, 2020

Conversation

mgarabed
Copy link
Member

@mgarabed mgarabed commented Mar 9, 2020

When an exception gets raised on a connection problem, this PR avoids nested exceptions by just popping up a single connection error and ignoring the context traceback.

@mgarabed mgarabed requested a review from a team as a code owner March 9, 2020 21:36
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also catch as e and log that (scrubbed)

@ofek ofek changed the title SQL Server - Streamline exception handling Streamline exception handling Mar 9, 2020
@ofek ofek merged commit e8a0a90 into master Mar 10, 2020
@ofek ofek deleted the mgarabed/sqlserver-exception branch March 10, 2020 14:04
ofek pushed a commit that referenced this pull request Mar 10, 2020
* Streamline exception handling

* Include original exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants