Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jmx endpoint work for local access #5831

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Make jmx endpoint work for local access #5831

merged 3 commits into from
Mar 2, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Feb 23, 2020 •
edited
Loading

Make jmx work for local access e.g. jconsole

@AlexandreYang AlexandreYang requested a review from a team as a code owner February 23, 2020 18:07
@codecov
Copy link

codecov bot commented Feb 23, 2020 •
edited
Loading

Codecov Report

Merging #5831 into master will decrease coverage by 26.84%.
The diff coverage is n/a.

Impacted Files Coverage Δ
oracle/datadog_checks/oracle/queries.py
envoy/tests/conftest.py
aerospike/tests/test_unit.py
...cks_base/datadog_checks/base/utils/db/transform.py
prometheus/tests/test_prometheus.py
ibm_db2/datadog_checks/ibm_db2/utils.py
gunicorn/tests/test_unit.py
...sos_master/datadog_checks/mesos_master/__init__.py
cilium/tests/conftest.py
ceph/tests/test_unit.py
... and 834 more

ofek
ofek reviewed Feb 23, 2020
View reviewed changes
activemq/tests/compose/docker-compose.yaml
@@ -5,8 +5,12 @@ services:
image: rmohr/activemq:${ACTIVEMQ_VERSION}
container_name: dd-test-activemq-server
environment:
ACTIVEMQ_SUNJMX_START: "-Dcom.sun.management.jmxremote.port=1616 -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false"
ACTIVEMQ_SUNJMX_START: >-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, clever!

@AlexandreYang AlexandreYang changed the title Make jmx work with jconsole Make jmx work for local access Feb 23, 2020
@AlexandreYang AlexandreYang requested a review from ofek February 24, 2020 21:42
@AlexandreYang AlexandreYang force-pushed the alex/activemq_jmx_jconsole branch from 14d8dfc to 86f8fc4 Compare February 24, 2020 21:43
@AlexandreYang AlexandreYang changed the title Make jmx work for local access [HOLD] Make jmx work for local access Feb 27, 2020
@AlexandreYang AlexandreYang changed the title [HOLD] Make jmx work for local access Make jmx work for local access Feb 27, 2020
@AlexandreYang AlexandreYang changed the title Make jmx work for local access Make jmx endpoint work for local access Mar 1, 2020
@AlexandreYang AlexandreYang merged commit 6424f9c into master Mar 2, 2020
@AlexandreYang AlexandreYang deleted the alex/activemq_jmx_jconsole branch March 2, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

@ofek ofek Awaiting requested review from ofek

Assignees
No one assigned
Labels
changelog/no-changelog integration/activemq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreYang @therve @ofek