Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable kafka_client_api_version option #5726

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

ian28223
Copy link
Contributor

@ian28223 ian28223 commented Feb 13, 2020

What does this PR do?

Re-enables kafka_client_api_version to pin the version.

Motivation

bug is now fixed upstream in kafka-python 2.0.0

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ofek ofek changed the title Reenable kafka_client_api_version Re-enable kafka_client_api_version option Feb 13, 2020
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@florimondmanca florimondmanca merged commit 53a2a76 into master Feb 17, 2020
@florimondmanca florimondmanca deleted the ian.bucad/kafkaadmin-api_version branch February 17, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants