Code

Add RethinkDB integration#5715

Code

Merged

florimondmanca merged 165 commits intomasterDataDog/integrations-core:masterfrom florimondmanca/rethinkdbDataDog/integrations-core:florimondmanca/rethinkdbCopy head branch name to clipboardMar 27, 2020

+2,731

Commits

Commits on Feb 12, 2020

• Add project skeleton

  

  Florimond Manca

  committed
  afb654a

  Copy full SHA for afb654a

• Add initial type hints

  

  Florimond Manca

  committed
  324b473

  Copy full SHA for 324b473

• Add rethinkdb to test-all-checks.yml

  

  Florimond Manca

  committed
  78e79e1

  Copy full SHA for 78e79e1

• Add short description

  

  Florimond Manca

  committed
  2f34ca9

  Copy full SHA for 2f34ca9

• Rename check class: Rethinkdb -> RethinkDB

  

  Florimond Manca

  committed
  1791c1f

  Copy full SHA for 1791c1f

• Add dependency on rethinkdb (Python driver)

  

  Florimond Manca

  committed
  a86ff28

  Copy full SHA for a86ff28

• Update signature used to instantiate check

  

  Florimond Manca

  committed
  fbd6ff2

  Copy full SHA for fbd6ff2

• Use Python 3.8 instead of 3.7 for Tox

  

  Florimond Manca

  committed
  0f6a392

  Copy full SHA for 0f6a392

• Setup Docker Compose

  

  Florimond Manca

  committed
  3ae1865

  Copy full SHA for 3ae1865

• Add E2E test

  

  Florimond Manca

  committed
  9d9a6e5

  Copy full SHA for 9d9a6e5

• Submit service check

  

  Florimond Manca

  committed
  72e9130

  Copy full SHA for 72e9130

• Allow viewing admin UI on localhost

  

  Florimond Manca

  committed
  699b073

  Copy full SHA for 699b073

• 🔥🐍2️⃣

  

  Florimond Manca

  committed
  79c5d69

  Copy full SHA for 79c5d69

• Simplify Python 2 import fix

  

  Florimond Manca

  committed
  cc5a2e1

  Copy full SHA for cc5a2e1

• Refactor submission of service check

  

  Florimond Manca

  committed
  678ed57

  Copy full SHA for 678ed57

Commits on Feb 13, 2020

• Collect cluster and server statistics

  

  Florimond Manca

  committed
  2f481a7

  Copy full SHA for 2f481a7

• Document more TODOs

  

  Florimond Manca

  committed
  a1a65b5

  Copy full SHA for a1a65b5

• Update jobs and current issues metrics listings

  

  Florimond Manca

  committed
  25ce3f0

  Copy full SHA for 25ce3f0

• Refactor collection of default metrics

  

  Florimond Manca

  committed
  1db5428

  Copy full SHA for 1db5428

Commits on Feb 14, 2020

• Add more nodes to cluster in Compose setup

  

  Florimond Manca

  committed
  9079a9a

  Copy full SHA for 9079a9a

• Turn rates into gauges

  

  Florimond Manca

  committed
  2c8cbc7

  Copy full SHA for 2c8cbc7

• Add logging to stats collection funcs

  

  Florimond Manca

  committed
  a32961a

  Copy full SHA for a32961a

• Check server tags, submit server tag in service check

  

  Florimond Manca

  committed
  9ade5d3

  Copy full SHA for 9ade5d3

• Make host and port instance-configurable, improve service check status

  

  Florimond Manca

  committed
  592766c

  Copy full SHA for 592766c

• Add config unit tests

  

  Florimond Manca

  committed
  46c28b6

  Copy full SHA for 46c28b6

• Test service check failure modes, add more logging

  

  Florimond Manca

  committed
  a1f7d7e

  Copy full SHA for a1f7d7e

• Fix mypy Config type detection

  

  Florimond Manca

  committed
  106b737

  Copy full SHA for 106b737

• Setup test data, fix and test table metrics

  

  Florimond Manca

  committed
  55524aa

  Copy full SHA for 55524aa

• Simplify usage of of eq_join

  

  Florimond Manca

  committed
  58bb8b8

  Copy full SHA for 58bb8b8

• Collect first replica metric

  

  Florimond Manca

  committed
  95af7c7

  Copy full SHA for 95af7c7

Commits on Feb 17, 2020

• Update disk metric names

  

  Florimond Manca

  committed
  b49c4a7

  Copy full SHA for b49c4a7

• Add the rest of replica stats metrics

  

  Florimond Manca

  committed
  97dce7d

  Copy full SHA for 97dce7d

• Drop index todo

  

  Florimond Manca

  committed
  2934e0a

  Copy full SHA for 2934e0a

• Add table status metrics

  

  Florimond Manca

  committed
  4a568e6

  Copy full SHA for 4a568e6

• Add server status metrics

  

  Florimond Manca

  committed
  4d32e58

  Copy full SHA for 4d32e58

• Fix timestamp on py2

  

  Florimond Manca

  committed
  61a6c6f

  Copy full SHA for 61a6c6f

• Add system job metrics, refactor assertions

  

  Florimond Manca

  committed
  6a36445

  Copy full SHA for 6a36445

• Add comments about cluster setup

  

  Florimond Manca

  committed
  f63d2d1

  Copy full SHA for f63d2d1

• Drop complicated integration setup in favor of jobs metrics unit tests

  

  Florimond Manca

  committed
  9912022

  Copy full SHA for 9912022

• Test unknown job types, simplify MockConnectionInstance

  

  Florimond Manca

  committed
  e69c6c3

  Copy full SHA for e69c6c3

• Cleanup, fix e2e test

  

  Florimond Manca

  committed
  2580123

  Copy full SHA for 2580123

• Use a more realistic client_port

  

  Florimond Manca

  committed
  e0098d4

  Copy full SHA for e0098d4

Commits on Feb 18, 2020

• Add default metrics flags

  

  Florimond Manca

  committed
  01018a0

  Copy full SHA for 01018a0

• Refactor service check submission, re-raise check errors for Agent-side logging

  

  Florimond Manca

  committed
  4debc73

  Copy full SHA for 4debc73

• Switch from rethinkdb.r.[...] to r.[...]

  

  Florimond Manca

  committed
  64b7238

  Copy full SHA for 64b7238

Commits on Feb 19, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  77acd89

  Copy full SHA for 77acd89

Commits on Feb 20, 2020

• Drop 'default_metrics' option

  

  Florimond Manca

  committed
  3d480dd

  Copy full SHA for 3d480dd

• Rename _default_metrics module to _metrics

  

  Florimond Manca

  committed
  0f2b93a

  Copy full SHA for 0f2b93a

Commits on Feb 24, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  7202dd7

  Copy full SHA for 7202dd7

• Drop query jobs metrics

  

  Florimond Manca

  committed
  dc558db

  Copy full SHA for dc558db

• Submit table status gauges as service checks

  

  Florimond Manca

  committed
  f45660e

  Copy full SHA for f45660e

• Submit replica state as a tag instead of metrics

  

  Florimond Manca

  committed
  1599f67

  Copy full SHA for 1599f67

• Handle disconnected replica server -- needs unit tests

  

  Florimond Manca

  committed
  d172f7b

  Copy full SHA for d172f7b

Commits on Feb 27, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  3a1b9d8

  Copy full SHA for 3a1b9d8

• Refactor submission of service check

  

  Florimond Manca

  committed
  56479b3

  Copy full SHA for 56479b3

• Lint

  

  Florimond Manca

  committed
  cd6a107

  Copy full SHA for cd6a107

• Add more debug logs

  

  Florimond Manca

  committed
  e34aee9

  Copy full SHA for e34aee9

• Improve robustness to disconnected servers

  

  Florimond Manca

  committed
  31cdbe5

  Copy full SHA for 31cdbe5

• Improve robustness of disconnect tests

  

  Florimond Manca

  committed
  1b0916e

  Copy full SHA for 1b0916e

• Nit: standardize imports

  

  Florimond Manca

  committed
  80de531

  Copy full SHA for 80de531

• Add more debug logs

  

  Florimond Manca

  committed
  86f342c

  Copy full SHA for 86f342c

• Ensure connection is closed after check

  

  Florimond Manca

  committed
  e1b01f4

  Copy full SHA for e1b01f4

• Get rid of 'r' imports, improve encapsulation of Config

  

  Florimond Manca

  committed
  5504f48

  Copy full SHA for 5504f48

• Rename test file, add missing copyright notice

  

  Florimond Manca

  committed
  fc76435

  Copy full SHA for fc76435

• Cleanup rethinkdb.py

  

  Florimond Manca

  committed
  9e7525c

  Copy full SHA for 9e7525c

Commits on Feb 28, 2020

• Lint

  

  Florimond Manca

  committed
  0da808f

  Copy full SHA for 0da808f

• Fix docstrings

  

  Florimond Manca

  committed
  1181b75

  Copy full SHA for 1181b75

• Add config totals metrics

  

  Florimond Manca

  committed
  45ca24a

  Copy full SHA for 45ca24a

• Add version metadata

  

  Florimond Manca

  committed
  3d07c6c

  Copy full SHA for 3d07c6c

• Add basic auth support, simplify cluster setup

  

  Florimond Manca

  committed
  412e743

  Copy full SHA for 412e743

• Add --disallow-untyped-defs mypy option

  

  Florimond Manca

  committed
  9e3c654

  Copy full SHA for 9e3c654

• Inject port for all 3 servers in Compose file

  

  Florimond Manca

  committed
  157efd4

  Copy full SHA for 157efd4

• Setup driver TLS on server1, prepare test

  

  Florimond Manca

  committed
  c9a0085

  Copy full SHA for c9a0085

Commits on Mar 2, 2020

• Implement TLS client cert support

  

  Florimond Manca

  committed
  9912ed1

  Copy full SHA for 9912ed1

• Introduce Connection interface

  

  Florimond Manca

  committed
  b900c48

  Copy full SHA for b900c48

• Collect and submit current issues metrics

  

  Florimond Manca

  committed
  f792bc7

  Copy full SHA for f792bc7

• Polish

  

  Florimond Manca

  committed
  03e82b9

  Copy full SHA for 03e82b9

• Write up README

  

  Florimond Manca

  committed
  b89c4ed

  Copy full SHA for b89c4ed

• Lint

  

  Florimond Manca

  committed
  3734e97

  Copy full SHA for 3734e97

• Add config spec

  

  Florimond Manca

  committed
  083eb95

  Copy full SHA for 083eb95

• Fill service_checks.json

  

  Florimond Manca

  committed
  d2cf6a1

  Copy full SHA for d2cf6a1

• Polish manifest.json

  

  Florimond Manca

  committed
  e4f6d70

  Copy full SHA for e4f6d70

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  2a06e6d

  Copy full SHA for 2a06e6d

Commits on Mar 3, 2020

• Update service check tags and service_checks.json

  

  Florimond Manca

  committed
  10c014e

  Copy full SHA for 10c014e

• Handle malformed version strings, improve test coverage

  

  Florimond Manca

  committed
  542531f

  Copy full SHA for 542531f

• Add py.typed

  

  Florimond Manca

  committed
  0f8b997

  Copy full SHA for 0f8b997

Commits on Mar 4, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  1a59087

  Copy full SHA for 1a59087

• Cleanup

  

  Florimond Manca

  committed
  c2db56a

  Copy full SHA for c2db56a

• Stick to non-private internal module names

  

  Florimond Manca

  committed
  5df6a56

  Copy full SHA for 5df6a56

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  6be71f0

  Copy full SHA for 6be71f0

• Move assertions to module, fix e2e test

  

  Florimond Manca

  committed
  0534f21

  Copy full SHA for 0534f21

Commits on Mar 5, 2020

• Rename 'user' option to 'username', clarify purpose of admin test

  

  Florimond Manca

  committed
  b8246a0

  Copy full SHA for b8246a0

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  d087d42

  Copy full SHA for d087d42

• Honor enable_metadata_collection config option

  

  Florimond Manca

  committed
  62cee74

  Copy full SHA for 62cee74

• Rename tests/_types.py -> tests/types.py

  

  Florimond Manca

  committed
  a4fb134

  Copy full SHA for a4fb134

• Reorganization test utils

  

  Florimond Manca

  committed
  57be056

  Copy full SHA for 57be056

• Parametrize log_patterns by server constants

  

  Florimond Manca

  committed
  e058f59

  Copy full SHA for e058f59

• Generate metadata.csv

  

  Florimond Manca

  committed
  5b1b69c

  Copy full SHA for 5b1b69c

• Fix wrong type of stats monotonic_count metrics

  

  Florimond Manca

  committed
  81ae697

  Copy full SHA for 81ae697

• Assert type of metrics

  

  Florimond Manca

  committed
  c123be5

  Copy full SHA for c123be5

• Fix E2E

  

  Florimond Manca

  committed
  6d44871

  Copy full SHA for 6d44871

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  172f6d1

  Copy full SHA for 172f6d1

Commits on Mar 6, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  4acd070

  Copy full SHA for 4acd070

• Improvement robustness of test cluster setup

  

  Florimond Manca

  committed
  6e63922

  Copy full SHA for 6e63922

• Drop dependency on mypy latest - for now

  

  Florimond Manca

  committed
  d526ec5

  Copy full SHA for d526ec5

Commits on Mar 9, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  9a90b39

  Copy full SHA for 9a90b39

• Address docs review

  

  Florimond Manca

  committed
  ca5c299

  Copy full SHA for ca5c299

Commits on Mar 13, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  f90797c

  Copy full SHA for f90797c

• Move any Config smarts to a Backend interface, update tests

  

  Florimond Manca

  committed
  91cc306

  Copy full SHA for 91cc306

• Wait for all server log patterns

  

  Florimond Manca

  committed
  467e126

  Copy full SHA for 467e126

Commits on Mar 16, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  e819a7d

  Copy full SHA for e819a7d

• Update note about tty: true

  

  Florimond Manca

  committed
  54a50f5

  Copy full SHA for 54a50f5

• Address feedback from @ofek

  

  Florimond Manca

  committed
  e23a2a4

  Copy full SHA for e23a2a4

• Tag current issues metrics by issue_type

  

  Florimond Manca

  committed
  b4a1c92

  Copy full SHA for b4a1c92

Commits on Mar 17, 2020

• Add support for custom tags

  

  Florimond Manca

  committed
  8701bca

  Copy full SHA for 8701bca

• Derive image and version from env

  

  Florimond Manca

  committed
  865420f

  Copy full SHA for 865420f

Commits on Mar 18, 2020

• Tweak coverage

  

  Florimond Manca

  committed
  43b580f

  Copy full SHA for 43b580f

• Cleanup, address feedback, more motivation docs

  

  Florimond Manca

  committed
  0fb3f79

  Copy full SHA for 0fb3f79

• TEMP: refactor metric collection

  

  Florimond Manca

  committed
  e60c27d

  Copy full SHA for e60c27d

Commits on Mar 19, 2020

• Simplify backends into a single class

  

  Florimond Manca

  committed
  26e7dc9

  Copy full SHA for 26e7dc9

• Simplify connection into a single class

  

  Florimond Manca

  committed
  c64e1e5

  Copy full SHA for c64e1e5

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  0f18673

  Copy full SHA for 0f18673

• Drop if/else switch on metric type

  

  Florimond Manca

  committed
  114b1f5

  Copy full SHA for 114b1f5

• Always submit the same tags regardless of connect service check status

  

  Florimond Manca

  committed
  4b81322

  Copy full SHA for 4b81322

• Dry up access to the system database

  

  Florimond Manca

  committed
  f123755

  Copy full SHA for f123755

• Clarify why job metrics are hard to test in integration/e2e

  

  Florimond Manca

  committed
  617a33f

  Copy full SHA for 617a33f

• Fix typo

  

  Florimond Manca

  committed
  63a2ddc

  Copy full SHA for 63a2ddc

• Revert "TEMP: refactor metric collection"

  Show description for ef58fac
  

  Florimond Manca

  committed
  ef58fac

  Copy full SHA for ef58fac

• Drop Connection class

  

  Florimond Manca

  committed
  f7d4c1c

  Copy full SHA for f7d4c1c

• Drop exceptions module

  

  Florimond Manca

  committed
  fc047d5

  Copy full SHA for fc047d5

• Fix unclear phrasing

  

  Florimond Manca

  committed
  9973b5a

  Copy full SHA for 9973b5a

• Get rid of Backend and QueryManager

  

  Florimond Manca

  committed
  f056285

  Copy full SHA for f056285

• Align metric names on JSON structure

  

  Florimond Manca

  committed
  a83cd97

  Copy full SHA for a83cd97

• Introduce and use DocumentQuery

  

  Florimond Manca

  committed
  130fc74

  Copy full SHA for 130fc74

• Pass check logger through

  

  Florimond Manca

  committed
  69686d2

  Copy full SHA for 69686d2

• Update metadata.csv

  

  Florimond Manca

  committed
  177065e

  Copy full SHA for 177065e

• Fix typo in to_timestamp util

  

  Florimond Manca

  committed
  173658e

  Copy full SHA for 173658e

• Add unit tests for document_db helpers

  

  Florimond Manca

  committed
  92ad5bd

  Copy full SHA for 92ad5bd

• Address feedback (part 1)

  

  Florimond Manca

  committed
  0ccb9ce

  Copy full SHA for 0ccb9ce

Commits on Mar 20, 2020

• Let long-lived query jobs pass through

  

  Florimond Manca

  committed
  444df24

  Copy full SHA for 444df24

• Drop unused Config repr

  

  Florimond Manca

  committed
  2d61475

  Copy full SHA for 2d61475

• Tweak version collection

  

  Florimond Manca

  committed
  862b5ab

  Copy full SHA for 862b5ab

• Test on 2.3 and latest

  

  Florimond Manca

  committed
  dc1a237

  Copy full SHA for dc1a237

• Update README with 2.3-compatible instructions, fix service check names

  

  Florimond Manca

  committed
  5b4e2e9

  Copy full SHA for 5b4e2e9

• Nits

  

  Florimond Manca

  committed
  efb97f7

  Copy full SHA for efb97f7

• Address feedback

  

  Florimond Manca

  committed
  5e7fc9f

  Copy full SHA for 5e7fc9f

Commits on Mar 24, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  f7a8f62

  Copy full SHA for f7a8f62

• Store service_check_tags as a tuple

  

  Florimond Manca

  committed
  edf3da5

  Copy full SHA for edf3da5

• Resolve flaky cluster setup on RethinkDB 2.3

  

  Florimond Manca

  committed
  6d58c6c

  Copy full SHA for 6d58c6c

• Add proxy check test, fix version handling for proxy

  

  Florimond Manca

  committed
  66b0dbc

  Copy full SHA for 66b0dbc

• Refactor version metadata tests

  

  Florimond Manca

  committed
  4e7f320

  Copy full SHA for 4e7f320

• Factorize integration tests

  

  Florimond Manca

  committed
  d2b56a8

  Copy full SHA for d2b56a8

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  27edb01

  Copy full SHA for 27edb01

Commits on Mar 25, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  0008149

  Copy full SHA for 0008149

• Add password sanitization

  

  Florimond Manca

  committed
  97db598

  Copy full SHA for 97db598

• Address feedback

  Show description for 3b65f86
  

  Florimond Manca

  committed
  3b65f86

  Copy full SHA for 3b65f86

Commits on Mar 26, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  01e7fae

  Copy full SHA for 01e7fae

• Refactor passing of logger to queries

  

  Florimond Manca

  committed
  b472756

  Copy full SHA for b472756

• Drop query duration metric

  

  Florimond Manca

  committed
  f03beb0

  Copy full SHA for f03beb0

• Address feedback

  

  Florimond Manca

  committed
  b9d3e92

  Copy full SHA for b9d3e92

• Drop detailed jobs metrics in favor of jobs summary

  

  Florimond Manca

  committed
  7d962c7

  Copy full SHA for 7d962c7

• Update metadata.csv

  

  Florimond Manca

  committed
  f478cbd

  Copy full SHA for f478cbd

• Fix E2E

  

  Florimond Manca

  committed
  a146b41

  Copy full SHA for a146b41

Commits on Mar 27, 2020

• Merge branch 'master' into florimondmanca/rethinkdb

  

  Florimond Manca

  committed
  bd4746d

  Copy full SHA for bd4746d

• Fix metric_to_check

  

  Florimond Manca

  committed
  8eee355

  Copy full SHA for 8eee355