Use top-level kafka imports to be more future-proof #5702

jeffwidman · 2020-02-11T18:29:31Z

Now that kafka-python 2.0 shipped, you can directly import the async client via the top level.

Now that `kafka-python` 2.0 shipped, you can directly import the async client via the top level.

jeffwidman · 2020-02-11T18:31:52Z

I threw this together using the GitHub Web UI, so because it touched two files it took two commits. So please squash when merging.

codecov · 2020-02-11T19:14:08Z

Codecov Report

Merging #5702 into master will decrease coverage by 7.20%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
process/tests/test_integration.py
squid/tests/test_squid.py
directory/tests/test_integration.py
marathon/datadog_checks/marathon/__init__.py
kubelet/tests/test_cadvisor.py
hdfs_datanode/tests/test_e2e.py
openldap/tests/test_unit.py
...ursor/datadog_checks/powerdns_recursor/__init__.py
ceph/tests/conftest.py
tls/datadog_checks/tls/utils.py
... and 941 more

jeffwidman · 2020-02-11T19:39:52Z

kafka_consumer/datadog_checks/kafka_consumer/legacy_0_10_2.py

 from kafka import KafkaClient
+from kafka import errors as kafka_errors


jeffwidman added 2 commits February 11, 2020 10:29

Use top-level import

0b88d4e

Now that `kafka-python` 2.0 shipped, you can directly import the async client via the top level.

squash me

709f8e7

jeffwidman marked this pull request as ready for review February 11, 2020 18:31

jeffwidman requested a review from a team as a code owner February 11, 2020 18:31

ofek added changelog/Added integration/kafka_consumer labels Feb 11, 2020

ofek changed the title ~~Use top-level import~~ Use top-level kafka imports to be more future-proof Feb 11, 2020

order imports

0cbca26

ofek approved these changes Feb 11, 2020

View reviewed changes

jeffwidman commented Feb 11, 2020

View reviewed changes

ofek merged commit 2c4c485 into DataDog:master Feb 11, 2020

		from kafka import KafkaClient
		from kafka import errors as kafka_errors