Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto_conf.yaml files #5678

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Add auto_conf.yaml files #5678

merged 1 commit into from
Feb 10, 2020

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Enable automatic autodiscovery for kube_scheduler and kube_controller_manager based on official images k8s.gcr.io/kube-scheduler and k8s.gcr.io/kube-controller-manager

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ahmed-mez ahmed-mez requested review from a team as code owners February 10, 2020 13:44
@ahmed-mez ahmed-mez merged commit e5f0946 into master Feb 10, 2020
@ahmed-mez ahmed-mez deleted the ahmed-mez/control-plane-AD branch February 10, 2020 15:13
@hithwen hithwen mentioned this pull request Feb 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vboulineau vboulineau vboulineau approved these changes

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
integration/kube_controller_manager integration/kube_scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmed-mez @ChristineTChen @vboulineau @ofek