Do not collect max, min and sum aggregates as they are the same as avg #5638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For realtime resources, we have always been collecting
max
,min
andraw
rollup metrics as long as theavg
one despite all of those having the exact same values. Indeed in this vsphere implementation, we collect only thelatest
point at the finest resolution. So rollup do not come into play.This PR prevents those extra rollup types to be collected and updates the fixture file accordingly.
Note: We could have removed all the remaining suffixes (
avg
,sum
andlatest
), but users are used to see them. Also havingsum
at the end helps to understand the metric is a "count" (I think). Additionally, the code-change would have been much bigger.Fixture file was updated with: