Raise exception to report when openmetrics process fails #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
| @@ -32,5 +32,6 @@ def process(self, scraper_config, metric_transformers=None): | |||
| super(LinkerdCheck, self).process(scraper_config, metric_transformers=metric_transformers) | |||
| except Exception: | |||
| self.gauge(self.HEALTH_METRIC, 1, tags=tags) | |||
| raise | |||
There was a problem hiding this comment.
Can we also log a message?
There was a problem hiding this comment.
Doesn't raise alone raises the same exception?
Reading this: https://docs.python.org/3/tutorial/errors.html#handling-exceptions I thought it would. I wanted to keep the exact same exception to display in the status.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Raise exception when openmetrics process method throws an exception, so the check reports it in the status of the agent.
Motivation
The integration reports OK even though there is a connection issue.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached