Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't provide a CLI entry point #5374

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Don't provide a CLI entry point #5374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d485330
Don't provide a CLI entry point
ofek Jan 2, 2020
bceaaa6
fix tests and README
trishankatdatadog Jan 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datadog_checks_downloader/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ To download a new or updated integration, you may specify a precise
[version][7]:

```shell
datadog-checks-downloader -vvvv datadog-$INTEGRATION --version X.Y.Z
python -m datadog_checks.downloader -vvvv datadog-$INTEGRATION --version X.Y.Z
```

Or you may leave the version unspecified to download the latest version:

```shell
datadog-checks-downloader -vvvv datadog-$INTEGRATION
python -m datadog_checks.downloader -vvvv datadog-$INTEGRATION
```

To run the tests, [install tox][8] and just run:
Expand Down
1 change: 0 additions & 1 deletion datadog_checks_downloader/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,4 @@ def get_requirements(fpath):
]
},
include_package_data=True,
entry_points={'console_scripts': ['datadog-checks-downloader=datadog_checks.downloader.cli:download']},
)
2 changes: 1 addition & 1 deletion datadog_checks_downloader/tests/test_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def download(package):
# -vvv: WARNING
# -vvvv: INFO
# -vvvvv: DEBUG
cmd = ['datadog-checks-downloader', '-vvvv', package]
cmd = ['python', '-m', 'datadog_checks.downloader', '-vvvv', package]
out = subprocess.check_output(cmd)
log.debug(' '.join(cmd))
log.debug(out)
Expand Down