Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct conversions from microseconds to seconds #5354

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

xornivore
Copy link
Contributor

@xornivore xornivore commented Dec 30, 2019

What does this PR do?

Correct math in conversion from microseconds to seconds in a couple of places in kube_scheduler.

Motivation

Correct metric values.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@xornivore xornivore requested review from clamoriniere and a team December 30, 2019 20:36
@xornivore xornivore requested a review from a team as a code owner December 30, 2019 20:36
@therve therve changed the title [kube_scheduler] Correct conversions from microseconds to seconds Correct conversions from microseconds to seconds Dec 31, 2019
Copy link
Contributor

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@xornivore xornivore changed the title Correct conversions from microseconds to seconds [kube_scheduler] Correct conversions from microseconds to seconds Dec 31, 2019
@xornivore xornivore changed the title [kube_scheduler] Correct conversions from microseconds to seconds Correct conversions from microseconds to seconds Dec 31, 2019
@xornivore xornivore merged commit f7f07ba into master Dec 31, 2019
@xornivore xornivore deleted the xornivore/kube_scheduler-correct-conversions branch December 31, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants