Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test environment for activemq #5204

Merged
merged 15 commits into from
Dec 23, 2019
Merged

Add test environment for activemq #5204

merged 15 commits into from
Dec 23, 2019

Conversation

mgarabed
Copy link
Member

What does this PR do?

In preparation for creating a native dashboard for ActiveMQ, this PR provides a basic E2E environment where JMX metrics can be extracted.

Additional Notes

Once the env has been started via ddev env start activemq py37, you can access the admin interface at the following url: http://localhost:8161/admin/

From there, you can add new queues or topics, then run ddev env check activemq py37 and see updated metrics in the output.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this! 💯

l0k0ms
l0k0ms previously approved these changes Dec 13, 2019
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2g for the doc 👍

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

mgarabed and others added 2 commits December 19, 2019 11:22
Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
@mgarabed mgarabed merged commit 561e217 into master Dec 23, 2019
@mgarabed mgarabed deleted the mgarabed/activemq_env branch December 23, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants