Remove shlex #5068

AlexandreYang · 2019-11-22T18:23:26Z

Remove shlex

shlex not supported on windows

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
PR title must be written as a CHANGELOG entry (see why)
Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
PR must have changelog/ and integration/ labels attached

codecov · 2019-11-22T18:33:38Z

Codecov Report

Merging #5068 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted Files	Coverage Δ
...og_checks/cassandra_nodetool/cassandra_nodetool.py	`88.88% <100%> (-0.16%)`	⬇️
vertica/tests/metrics.py
...checks_dev/tests/plugin/test_environment_runner.py
riakcs/datadog_checks/riakcs/riakcs.py
oracle/tests/test_oracle.py
...r/datadog_checks/openstack_controller/__about__.py
twistlock/datadog_checks/twistlock/twistlock.py
linkerd/datadog_checks/linkerd/linkerd.py
...oller/datadog_checks/openstack_controller/utils.py
istio/tests/test_e2e.py
... and 847 more

Remove shlex

8acc6aa

AlexandreYang added integration/cassandra_nodetool changelog/Fixed labels Nov 22, 2019

AlexandreYang requested a review from a team as a code owner November 22, 2019 18:23

AlexandreYang requested a review from therve November 22, 2019 18:23

ofek approved these changes Nov 24, 2019

View reviewed changes

AlexandreYang merged commit 0805d8d into master Nov 25, 2019

AlexandreYang deleted the alex/cassandra_nodetool_remove_shlex branch November 25, 2019 08:49