-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kafka_client_api_version
#5007
Conversation
each instance could potentially have different api_versions, connections, etc
Codecov Report
|
Alternatively, can we path kafka-python the same as how we did it with jaydebeapi (DataDog/datadog-agent#4402)? we just need to insert 1 line at kafka/admin/client.py https://github.com/dpkp/kafka-python/pull/1953/files |
Co-Authored-By: Julia <611228+hithwen@users.noreply.github.com>
This reverts commit 71e10ec.
What does this PR do?
fixes an issue when pinning the
api_version
.2 issues:
api_version
expects a tuple butkafka_client_api_version
is a stringKafkaAdminClient
where pinning anyapi_version
will raise anIncompatibleBrokerVersion
. Settingapi_version=None
would be a temporary fix.Motivation
found bug while investigating something.
Additional Notes
IncompatibleBrokerVersion
when passing anapi_version
dpkp/kafka-python#1953Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached