Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle topics set to empty dict #4974

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Handle topics set to empty dict #4974

merged 1 commit into from
Nov 7, 2019

Conversation

therve
Copy link
Contributor

@therve therve commented Nov 7, 2019

The doc already points to {} instead of None for retrieving the topics,
let's check both.

The doc already points to {} instead of None for retrieving the topics,
let's check both.
@therve therve merged commit e566013 into master Nov 7, 2019
@therve therve deleted the therve/kafka-no-topics branch November 7, 2019 18:18
@jeffwidman
Copy link
Contributor

jeffwidman commented Feb 5, 2020

It's been a little while, so my memory is hazy, but I recall this being a purposeful design choice so that a user can say "I want to get only the broker highwater offsets associated with these consumer groups, w/o getting the consumer offsets".

With this change, I don't think that's possible? To be clear, I have no objections to this change, just wanted to mention the original intent here.

Again, it's been a while since I wrote this so I may be completely misremembering.

Similar thing I think (but am not sure) applies to #5035.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants