Fix error on missing config #4959

therve · 2019-11-06T09:24:35Z

The ConfigurationError raised when there are no consumer groups
referenced an unknown attribute.

The ConfigurationError raised when there are no consumer groups referenced an unknown attribute.

kafka_consumer/datadog_checks/kafka_consumer/kafka_consumer.py

codecov · 2019-11-06T09:46:16Z

Codecov Report

Merging #4959 into master will decrease coverage by 11.31%.
The diff coverage is 100%.

Impacted Files	Coverage Δ
...er/datadog_checks/kafka_consumer/kafka_consumer.py	`68.18% <ø> (ø)`
kafka_consumer/tests/test_kafka_consumer.py	`92.85% <100%> (ø)`
...checks_dev/tests/plugin/test_environment_runner.py
oracle/tests/test_oracle.py
...r/datadog_checks/openstack_controller/__about__.py
twistlock/datadog_checks/twistlock/twistlock.py
linkerd/datadog_checks/linkerd/linkerd.py
...oller/datadog_checks/openstack_controller/utils.py
istio/tests/test_e2e.py
gitlab_runner/tests/test_integration.py
... and 819 more

Fix error on missing config

65e7109

The ConfigurationError raised when there are no consumer groups referenced an unknown attribute.

therve requested a review from a team as a code owner November 6, 2019 09:24

therve added changelog/Fixed integration/kafka_consumer labels Nov 6, 2019

AlexandreYang requested changes Nov 6, 2019

View reviewed changes

kafka_consumer/datadog_checks/kafka_consumer/kafka_consumer.py Show resolved Hide resolved

Add test for configuration error

91aa419

AlexandreYang previously approved these changes Nov 6, 2019

View reviewed changes

Style

61902c9

therve dismissed AlexandreYang’s stale review via 61902c9 November 6, 2019 12:44

AlexandreYang approved these changes Nov 6, 2019

View reviewed changes

therve merged commit db74411 into master Nov 6, 2019

therve deleted the therve/kafka-config-error branch November 6, 2019 13:36