Add auth type to RequestsWrapper #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
|
currently failing some style tests and the test for lighttpd. Failing lighttpd should be expected. |
ofek
requested changes
Oct 9, 2019
hithwen
previously approved these changes
Oct 10, 2019
|
cc @ruthnaebeck for docs |
ruthnaebeck
suggested changes
Oct 10, 2019
hithwen
previously approved these changes
Oct 11, 2019
ofek
requested changes
Oct 11, 2019
| @@ -62,6 +62,7 @@ | |||
| 'tls_verify': True, | |||
| 'timeout': DEFAULT_TIMEOUT, | |||
| 'username': None, | |||
| 'auth_type': None, | |||
There was a problem hiding this comment.
Let's keep it in alphabetical order
| auth = (config['username'], config['password']) | ||
| if config['auth_type']: | ||
| auth_type = config.get('auth_type', 'basic').lower() | ||
| if auth_type not in ('basic', 'digest'): |
There was a problem hiding this comment.
Let's check for each then log in an else branch. Also, make the first be if auth_type == 'basic':
ofek
requested changes
Oct 11, 2019
hithwen
reviewed
Oct 16, 2019
8acba15 to
ed95149
Compare
itsdanni
commented
Oct 22, 2019
hithwen
reviewed
Oct 23, 2019
| elif auth_type == 'digest': | ||
| auth = requests.auth.HTTPDigestAuth(config['username'], config['password']) | ||
| else: | ||
| self.logger.debug('auth_type {} is not supported, defaulting to basic'.format(auth_type)) |
There was a problem hiding this comment.
Suggested change
| self.logger.debug('auth_type {} is not supported, defaulting to basic'.format(auth_type)) | |
| self.logger.warning('auth_type {} is not supported, defaulting to basic'.format(auth_type)) |
I think we want this to appear on the logs without needing to enable debug
FlorianVeaux
requested changes
Oct 23, 2019
FlorianVeaux
approved these changes
Oct 25, 2019
ofek
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this card: https://trello.com/c/HGVH9yKS/790-add-authtype-to-requestswrapper