Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to override KRB5CCNAME env var #4578

Merged
merged 7 commits into from
Sep 23, 2019
Merged

Add option to override KRB5CCNAME env var #4578

merged 7 commits into from
Sep 23, 2019

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Sep 19, 2019

Adds the ability to set KRB5CCNAME per integration

Check https://web.mit.edu/kerberos/krb5-1.12/doc/basic/ccache_def.html and https://github.com/requests/requests-kerberos for more info

@hithwen hithwen requested review from a team as code owners September 19, 2019 10:05
@codecov
Copy link

codecov bot commented Sep 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6109caf). Click here to learn what that means.
The diff coverage is 100%.

Impacted Files Coverage Δ
datadog_checks_base/tests/test_http.py 98.26% <100%> (ø)
...adog_checks_base/datadog_checks/base/utils/http.py 100% <100%> (ø)

@hithwen
Update http.py
7923ea2 
keep options in alphabetical order
ofek
ofek approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

ofek
ofek previously approved these changes Sep 19, 2019
View reviewed changes
@hithwen hithwen requested a review from ruthnaebeck September 20, 2019 09:41
AlexandreYang
AlexandreYang previously approved these changes Sep 20, 2019
View reviewed changes
@hithwen hithwen merged commit 468f91b into master Sep 23, 2019
@hithwen hithwen deleted the julia/kerberos-cache-file branch September 23, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang approved these changes

@ofek ofek ofek left review comments

@ruthnaebeck ruthnaebeck Awaiting requested review from ruthnaebeck

Assignees
No one assigned
Labels
integration/activemq integration/apache integration/consul integration/couch integration/couchbase integration/datadog_checks_base integration/druid integration/ecs_fargate integration/elastic integration/envoy integration/etcd integration/fluentd integration/gitlab_runner integration/go_expvar integration/haproxy integration/hdfs_datanode integration/hdfs_namenode integration/http_check integration/kyototycoon integration/lighttpd integration/mapreduce integration/marathon integration/mesos_master integration/nginx integration/openstack_controller integration/php_fpm integration/powerdns_recursor integration/rabbitmq integration/spark integration/squid integration/teamcity integration/vault integration/yarn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hithwen @ofek @ruthnaebeck @AlexandreYang