Remove rarely used zookeeper-specific min collection interval #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a feature I'd pushed for several years ago to support fetching consumer offsets from Zookeeper at a different rate than from Kafka. However, now that Agent v6 supports setting `min_collection_interval` at the instance level, this is no longer needed... instead, just configure two separate instances of the check--one for kafka and one for zookeeper. So removing this code to simplify the legacy check and making the setting a no-op.
Codecov Report
|
|
@jeffwidman no need to apologize for anything! We truly appreciate your contributions and are always grateful for them and for the insights you've provided! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a feature I'd pushed for several years ago to support fetching
consumer offsets from Zookeeper at a different rate than from Kafka.
However, now that Agent v6 supports setting
min_collection_intervalatthe instance level, this is no longer needed... instead, just configure
two separate instances of the check--one for kafka and one for
zookeeper.
So removing this code to simplify the legacy check. I would be very surprised if anyone ever actually used this, so I think it's very safe to make this a no-op, especially as fetching consumer offsets from Zookeeper is in the process of being deprecated.
Also, my apologies @truthbk for wasting your time when I pushed for implementing this feature!