Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coredns prometheus health and ksm cronjob sc #3903

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Add coredns prometheus health and ksm cronjob sc #3903

merged 3 commits into from
Jun 18, 2019

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented Jun 12, 2019 •
edited
Loading

What does this PR do?

Adds service checks for CoreDNS and ksm. Those were missing when creating integration monitors.

Motivation

Customer request.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@dabcoder dabcoder requested review from a team as code owners June 12, 2019 08:23
hithwen
hithwen requested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@hithwen hithwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme should be updated accordingly

@dabcoder dabcoder requested review from a team as code owners June 12, 2019 12:56
FlorianVeaux
FlorianVeaux previously approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
The service check job will have to be re-run once this is merged

apigirl
apigirl previously approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small suggestion

coredns/README.md Outdated
The CoreDNS check does not include any service checks.
`coredns.prometheus.health`:

Returns CRITICAL if the Agent cannot reach the metrics endpoints.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Returns CRITICAL if the Agent cannot reach the metrics endpoints.
Returns `CRITICAL` if the Agent cannot reach the metrics endpoints.

@dabcoder dabcoder dismissed stale reviews from apigirl and FlorianVeaux via a8dcb1d June 18, 2019 15:14
@FlorianVeaux FlorianVeaux merged commit c17f207 into master Jun 18, 2019
@l0k0ms l0k0ms deleted the davidb/service-checks-coredns-ksm branch June 19, 2019 06:25
@dabcoder dabcoder mentioned this pull request Jun 19, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

@apigirl apigirl apigirl left review comments

@FlorianVeaux FlorianVeaux FlorianVeaux left review comments

Assignees
No one assigned
Labels
changelog/no-changelog integration/coredns integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dabcoder @hithwen @FlorianVeaux @apigirl