-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swap memory checks to cadvisor kubelet checks #3808
Conversation
cc @grosser |
Thanks for this contribution! At a glance that sounds like a helpful change! Any way you can add the metrics to this file https://github.com/DataDog/integrations-core/blob/master/kubelet/metadata.csv ? |
dd476e8
to
ed538d9
Compare
a762a18
to
ae94ebf
Compare
@CharlyF Added metrics to the metadata.csv and added tests for new metrics. |
ae94ebf
to
4f670d2
Compare
This reverts commit 44b284c.
What does this PR do?
Add swap memory checks to cadvisor kubelet checks
Motivation
cadvisor supports swap memory metrics via prometheus that is not exposed with the datadog integration by default.
Additional Notes
Wasn't able to work out how to test our Docker agent with a separate version of integrations-core...
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached