Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swap memory checks to cadvisor kubelet checks #3808

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

adammw
Copy link
Contributor

@adammw adammw commented May 24, 2019

What does this PR do?

Add swap memory checks to cadvisor kubelet checks

Motivation

cadvisor supports swap memory metrics via prometheus that is not exposed with the datadog integration by default.

Additional Notes

Wasn't able to work out how to test our Docker agent with a separate version of integrations-core...

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@adammw adammw requested review from a team as code owners May 24, 2019 17:57
@adammw
Copy link
Contributor Author

adammw commented May 24, 2019

cc @grosser

@CharlyF
Copy link
Contributor

CharlyF commented May 24, 2019

Thanks for this contribution!

At a glance that sounds like a helpful change!

Any way you can add the metrics to this file https://github.com/DataDog/integrations-core/blob/master/kubelet/metadata.csv ?
Also, I think the new metrics have to be referenced in the test https://github.com/DataDog/integrations-core/blob/master/kubelet/tests/test_kubelet.py#L37 for the CI to be OK.

@adammw adammw force-pushed the adammw/kubelet-swap branch 2 times, most recently from dd476e8 to ed538d9 Compare June 1, 2019 01:28
@adammw adammw requested review from a team as code owners June 1, 2019 01:28
@adammw adammw force-pushed the adammw/kubelet-swap branch 3 times, most recently from a762a18 to ae94ebf Compare June 1, 2019 01:47
@adammw
Copy link
Contributor Author

adammw commented Jun 1, 2019

@CharlyF Added metrics to the metadata.csv and added tests for new metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants