Check error code of nodetool command #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
approved these changes
Apr 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #3632 +/- ##
==========================================
+ Coverage 86.02% 94.48% +8.45%
==========================================
Files 741 7 -734
Lines 38996 145 -38851
Branches 4682 16 -4666
==========================================
- Hits 33546 137 -33409
+ Misses 4178 4 -4174
+ Partials 1272 4 -1268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks the error code of the nodetool command so that it logs an error if
it's not 0.
The command doesn't seem to use stderr, so checking err is not really useful,
and using the "Error:" prefix is not good enough as it's not present all the
time. This should fix it.
It also fixes the docker environment building so that it works with non local docker.