Adhere to code style #3550
Merged
Adhere to code style #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3550 +/- ##
===========================================
- Coverage 86.52% 51.19% -35.33%
===========================================
Files 726 5 -721
Lines 37524 920 -36604
Branches 4393 129 -4264
===========================================
- Hits 32466 471 -31995
+ Misses 3867 426 -3441
+ Partials 1191 23 -1168 |
therve
requested changes
Apr 12, 2019
| @@ -760,7 +759,7 @@ def get_nova_endpoint(self, instance=None): | |||
| def _parse_uptime_string(self, uptime): | |||
| """ Parse u' 16:53:48 up 1 day, 21:34, 3 users, load average: 0.04, 0.14, 0.19\n' """ | |||
| uptime = uptime.strip() | |||
| load_averages = uptime[uptime.find('load average:'):].split(':')[1].split(',') | |||
| load_averages = uptime[uptime.find('load average:') :].split(':')[1].split(',') | |||
There was a problem hiding this comment.
That looks unexpected. An issue with black?
There was a problem hiding this comment.
therve
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Standardize code formatting across all integrations