Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not tag container restarts/state metrics by container_id anymore #3424

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Mar 29, 2019

What does this PR do?

Use orchestrator cardinality for metrics from _report_container_state_metrics. This requires the new 6.11+ tagger API and has two reasons:

  • these metrics are not directly tied to the container_id, but to the pod_name + kube_container_name (restarts is the number of restarts BEFORE the current container)
  • tagging per container_id churned the timeseries at every restart

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #3424 into master will increase coverage by 3.58%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #3424      +/-   ##
==========================================
+ Coverage   86.24%   89.83%   +3.58%     
==========================================
  Files         718       10     -708     
  Lines       36556     1249   -35307     
  Branches     4298      173    -4125     
==========================================
- Hits        31528     1122   -30406     
+ Misses       3845       85    -3760     
+ Partials     1183       42    -1141

@xvello xvello force-pushed the xvello/new-tagger-kubelet branch from 2ab033b to 2ad4b92 Compare March 29, 2019 13:47
mfpierre
mfpierre previously approved these changes Mar 29, 2019
@xvello xvello merged commit 0568dd2 into master Mar 29, 2019
@xvello xvello deleted the xvello/new-tagger-kubelet branch March 29, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants