Properly cache zookeeper connection strings #3333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Properly uses the last_zk seen cache for the case when users provided a list of connection strings. Before we were assuming there was only one.
Also adds the exception to an error message we provide.
Motivation
We accept both a string and a list of strings for
zk_connect_str
in the yaml file. However, the _should_zk function was attempting to use this to access a dictionary. In the case of it being a list, you'd end up with an exception about list being an unhashable type. This addresses that, with a test :)Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached