Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS integration #3256

Merged
merged 25 commits into from
Apr 17, 2019
Merged

Add TLS integration #3256

merged 25 commits into from
Apr 17, 2019

Conversation

rsheyd
Copy link
Contributor

@rsheyd rsheyd commented Mar 7, 2019 •
edited by Azoam
Loading

What does this PR do?

Adds a new dedicated SSL certificate check integration.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@rsheyd rsheyd requested review from a team as code owners March 7, 2019 16:49
@codecov
Copy link

codecov bot commented Mar 7, 2019 •
edited
Loading

Codecov Report

Merging #3256 into master will decrease coverage by 0.64%.
The diff coverage is 99.13%.

@@            Coverage Diff             @@
##           master    #3256      +/-   ##
==========================================
- Coverage   86.51%   85.86%   -0.65%     
==========================================
  Files         737       79     -658     
  Lines       37981     5518   -32463     
  Branches     4462      625    -3837     
==========================================
- Hits        32859     4738   -28121     
+ Misses       3919      651    -3268     
+ Partials     1203      129    -1074

gzussa
gzussa suggested changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a quick look on this PR and then realized it was WIP. I hope it will help anyway.

ssl/tox.ini Outdated Show resolved Hide resolved
ssl/tox.ini Outdated Show resolved Hide resolved
ssl/tests/conftest.py Outdated Show resolved Hide resolved
ssl/setup.py Outdated Show resolved Hide resolved
ssl/my-ssl.py Outdated Show resolved Hide resolved
ssl/manifest.json Outdated Show resolved Hide resolved
ssl/manifest.json Outdated Show resolved Hide resolved
ssl/logos/README.md Outdated Show resolved Hide resolved
ssl/tcp-ssl.py Outdated Show resolved Hide resolved
ssl/datadog_checks/ssl/data/conf.yaml.example Outdated Show resolved Hide resolved
@ofek ofek force-pushed the rsheyd/ssl-check branch 7 times, most recently from 18e576a to 12127ce Compare March 31, 2019 19:11
@rsheyd rsheyd requested a review from a team as a code owner March 31, 2019 19:11
@ofek ofek force-pushed the rsheyd/ssl-check branch 4 times, most recently from 136bad6 to b7a1fce Compare March 31, 2019 23:53
@ofek ofek changed the title Add SSL Certificate Check Integration Add TLS integration Mar 31, 2019
@ofek ofek force-pushed the rsheyd/ssl-check branch 8 times, most recently from 7bc01d6 to 67aa6c7 Compare April 2, 2019 01:36
@ofek ofek force-pushed the rsheyd/ssl-check branch from b20bb99 to 58c5c15 Compare April 11, 2019 15:35
@ofek ofek mentioned this pull request Apr 12, 2019
Merged
nmuesch
nmuesch requested changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@nmuesch nmuesch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good. Just left a handful of comments/questions. 💜 🥇 on all the solid tests btw!

tls/README.md Show resolved Hide resolved
tls/datadog_checks/tls/data/conf.yaml.example Outdated Show resolved Hide resolved
tls/datadog_checks/tls/data/conf.yaml.example Outdated Show resolved Hide resolved
tls/datadog_checks/tls/data/conf.yaml.example Outdated Show resolved Hide resolved
tls/README.md Outdated Show resolved Hide resolved
tls/datadog_checks/tls/tls.py Outdated Show resolved Hide resolved
tls/datadog_checks/tls/tls.py Show resolved Hide resolved
tls/datadog_checks/tls/tls.py Show resolved Hide resolved
tls/datadog_checks/tls/utils.py Show resolved Hide resolved
tls/tests/test_local.py Show resolved Hide resolved
nmuesch
nmuesch previously approved these changes Apr 16, 2019
View reviewed changes
Copy link
Collaborator

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and all the tests 🙇

gzussa
gzussa previously approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@gzussa gzussa requested a review from l0k0ms April 16, 2019 17:57
@l0k0ms l0k0ms dismissed stale reviews from gzussa and nmuesch via 851423e April 16, 2019 18:14
@ofek ofek merged commit 2a9fd04 into master Apr 17, 2019
@ofek ofek deleted the rsheyd/ssl-check branch April 17, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthnaebeck ruthnaebeck ruthnaebeck left review comments

@zippolyte zippolyte zippolyte left review comments

@ofek ofek ofek left review comments

@gzussa gzussa gzussa left review comments

@therve therve therve left review comments

@l0k0ms l0k0ms l0k0ms approved these changes

@nmuesch nmuesch nmuesch left review comments

Assignees
No one assigned
Labels
documentation integration/tls kind/new-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rsheyd @therve @gzussa @l0k0ms @nmuesch @ofek @zippolyte @ruthnaebeck