Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure_unicode with normalize for py3 compatibility #3218

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

gzussa
Copy link
Contributor

@gzussa gzussa commented Feb 27, 2019

What does this PR do?

normalize is being ensure_unicode almost everywhere but not everywhere.
Hence, I am moving the logic as part of the normalize method since it needs to be done all the time.

Motivation

Python 3 compatibility

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #3218 into master will increase coverage by 0.52%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
+ Coverage    83.1%   83.62%   +0.52%     
==========================================
  Files         707      700       -7     
  Lines       39356    38667     -689     
  Branches     4684     4613      -71     
==========================================
- Hits        32705    32336     -369     
+ Misses       5254     4973     -281     
+ Partials     1397     1358      -39

@gzussa gzussa changed the title ensure_unicode with normalize for py3 compatibility [ci run all] ensure_unicode with normalize for py3 compatibility Feb 27, 2019
@gzussa gzussa changed the title [ci run all] ensure_unicode with normalize for py3 compatibility ensure_unicode with normalize for py3 compatibility Feb 27, 2019
@gzussa gzussa merged commit 4a71050 into master Feb 27, 2019
@gzussa gzussa deleted the gzu/normalize_unicode branch February 27, 2019 17:01
@therve therve mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants